Use correct flag to determine if V8 Sandboxing is enabled#1373
Merged
JoshuaWise merged 1 commit intoWiseLibs:masterfrom May 19, 2025
Merged
Use correct flag to determine if V8 Sandboxing is enabled#1373JoshuaWise merged 1 commit intoWiseLibs:masterfrom
JoshuaWise merged 1 commit intoWiseLibs:masterfrom
Conversation
mceachen
approved these changes
May 10, 2025
Member
mceachen
left a comment
There was a problem hiding this comment.
Thank you for doing this research!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron switched to using v8's sandboxing feature as of V21. With this enabled, allocating a buffer using
node::Buffer::Newcrashes the program, because it attempts to allocate memory outside of the allowed memory address range of the sandbox.Reproducing the issue is as simple as calling
db.serialize()in Electron versions 30.0 and higher.PR #1036 fixed this for electron versions until 30.x.x+, where this fix broke. Why this only broke in the most recent Electron versions, I'm not sure, but there were 2 issues:
V8_ENABLE_SANDBOX. This is also the flag that Electron uses: https://github.com/electron/electron/blob/main/patches/node/support_v8_sandboxed_pointers.patchI tested the minimum repro with these changes inside of an Electron app, and it behaves as expected now. (#1372 )